[Webkit-unassigned] [Bug 150693] Tapping and holding a link should have a share option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 12:40:54 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=150693

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #6)
> Comment on attachment 264406 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264406&action=review
> 
> >> Source/WebKit2/UIProcess/ios/WKPDFView.mm:726
> >> +    if ([_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)])
> > 
> > Wonder if we still need all these respondsToSelector checks these days.
> 
> I don't think we do need the responds to selector here.

Thank you Enrica and Tim! 

Checked in http://trac.webkit.org/changeset/191805

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151030/595aeccb/attachment.html>


More information about the webkit-unassigned mailing list