[Webkit-unassigned] [Bug 150693] Tapping and holding a link should have a share option

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150693

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264406|review?                     |review+
              Flags|                            |

--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 264406
  --> https://bugs.webkit.org/attachment.cgi?id=264406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264406&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKElementAction.mm:133
> +            NSLog(@"actionInfo._interactionLocation for share item is %@", NSStringFromPoint(actionInfo._interactionLocation));

Please no.

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:726
> +    if ([_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)])

Wonder if we still need all these respondsToSelector checks these days.

> Source/WebKit2/UIProcess/ios/WKPDFView.mm:727
> +        [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect];

url.absoluteString (and above too)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151030/8c4b1142/attachment.html>