[Webkit-unassigned] [Bug 150590] [GTK] Use a persistent main loop source in RunLoop glib implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150590

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264130|0                           |1
        is obsolete|                            |

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 264389
  --> https://bugs.webkit.org/attachment.cgi?id=264389&action=review
Patch for landing

Found the problem of the timeouts in the bots. I was cancelling the persistent source in RunLoop:stop(). In case of nested main loop, if there are pedning tasks in the parent loop, the source is invalidated and the pending tasks are never done. We don't really need to cancel the source on stop, since the main loop will be stopped anyway and the main context won't process more sources. So, this patch simply removes the set_ready_time to -1 line in RunLoop::stop()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151030/f2602eb7/attachment-0001.html>