[Webkit-unassigned] [Bug 150464] [WinCairo] Improve test results for fast layouttests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 23 12:30:03 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=150464

--- Comment #10 from peavo at outlook.com ---
(In reply to comment #9)
> Comment on attachment 263918 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263918&action=review
> 
> > Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:-84
> > -    ascent = ascentConsideringMacAscentHack(faceName.data(), ascent, descent);
> 
> On second thought, removing this would make the Windows ports more
> different, which would make them harder to test, wouldn't it?

Sorry, I don't quite understand what you mean :) This is only for WinCairo, and should make the font metrics less different than before. I think we should only apply the Mac ascent adjustment for CoreGraphics platforms.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151023/b49c9fb9/attachment-0001.html>


More information about the webkit-unassigned mailing list