[Webkit-unassigned] [Bug 150385] ConvolverNode.buffer must have same sample rate as the AudioContext

Thu Oct 22 15:53:23 PDT 2015

https://bugs.webkit.org/show_bug.cgi?id=150385

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263797|                            |commit-queue-
              Flags|                            |

--- Comment #28 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 263797
  --> https://bugs.webkit.org/attachment.cgi?id=263797
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263797&action=review

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:1
> +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<!DOCTYPE html>

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:9
> +<div id="description"></div>

Not needed.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:10
> +<div id="console"></div>

Not needed.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:15
> +function runTest()

You don't really need a function.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:17
> +    if (window.testRunner) {

This whole if block is not needed.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:22
> +    window.jsTestIsAsync = true;

I don't see why this test needs to be async.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:25
> +    var conv = context.createConvolver();

No abbreviations in variable names please.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:27
> +    try {

shouldThrow("conv.buffer = context.createBuffer(1, 256, 22050)", "'Error: NOT_SUPPORTED_ERR'"); (or similar).

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:37
> +    try {

Could use shouldThrow() as well.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:44
> +    finishJSTest();

Not needed.

> LayoutTests/webaudio/convolver-setBuffer-different-samplerate.html:48
> +successfullyParsed = true;

Should not be needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151022/daaa1313/attachment.html>