[Webkit-unassigned] [Bug 150451] [Win] Add support for the USE_TYPO_METRICS flag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150451

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263847|                            |review?
              Flags|                            |

--- Comment #4 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 263847
  --> https://bugs.webkit.org/attachment.cgi?id=263847
Patch V2

Just asking a first review to get some feedback...

The patch has *not* been verified on a Windows machine.

The style error is bug 150396 and it seems that we can not workaround that because kCTFontTableOS2 is not defined on Windows. Maybe this requires an additional header but I can't find a public documentation for Windows.

It's a shame that the CGFont API does not have a more straightforward way to access the typo metrics. For SimpleFontDataCGWin, I just copied & adapted what was done for Mac in bug 150396. I'm afraid the same will be necessary for iOS...

As said in bug 150394 comment 13, I can add more code to restrict this change to font with a MATH table if that's desired. Again, the CGFont API does not seem to have a simple & fast way to verify whether a MATH table is present, so in bug 150394 I just adapted the fontHasVerticalGlyphs function from FontCocoa.mm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151022/0d928158/attachment.html>