[Webkit-unassigned] [Bug 150446] New: Clean binding generated code for attribute setters and getters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150446

            Bug ID: 150446
           Summary: Clean binding generated code for attribute setters and
                    getters
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: youennf at gmail.com

As pointed out by Ossy in bug 150438, the binding generator code for custom attribute getters and/or setters should be fixed:

> > Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:158
> > +EncodedJSValue jsTestJSBuiltinConstructorTestAttributeCustom(ExecState* state, JSObject* slotBase, EncodedJSValue thisValue, PropertyName)
> > +{
> > +    UNUSED_PARAM(state);
> > +    UNUSED_PARAM(slotBase);
> > +    UNUSED_PARAM(thisValue);
> > +    auto* castedThis = jsCast<JSTestJSBuiltinConstructor*>(slotBase);
> > +    return JSValue::encode(castedThis->testAttributeCustom(*state));
> > +}
> 
> state and slotBase parameters are used. thisValue is really unused, 
> but in this case omitting the parameter name would be better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151022/48f2541b/attachment-0001.html>