[Webkit-unassigned] [Bug 147824] NetworkProcess: DNS prefetch happens in the Web Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147824

--- Comment #28 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #27)
> Comment on attachment 263456 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263456&action=review
> 
> r=me

Thanks!

> > Source/WebKit2/WebProcess/WebProcess.cpp:167
> > +    , m_dnsPrefetchedHostsCleanupHysteresis(std::bind(&WebProcess::dnsPrefetchedHostsCleanupHysteresisUpdated, this, std::placeholders::_1))
> 
> Could have also been all in one line:
> , m_dnsPrefetchHysteresis([this] (HystererisState state) { if (state ==
> HysteresisState::Stopped) m_dnsPrefetchedHosts.clear(); });

Yes, I thought about that, but discarded it to avoid the single line if, but being a single statement if it doesn't look that bad, I'll change it.

> > Source/WebKit2/WebProcess/WebProcess.h:368
> > +    WebCore::HysteresisActivity m_dnsPrefetchedHostsCleanupHysteresis;
> 
> I prefer the naming: m_dnsPrefetchHystereris. This way when the activity
> stops, it is clearer that what stopped is a DNS prefetching activity.

Agree

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151021/5efbe788/attachment.html>