[Webkit-unassigned] [Bug 150056] run-webkit-tests does not copy all crash logs for layout test failures on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150056

Aakash Jain <aakash_jain at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263542|0                           |1
        is obsolete|                            |
 Attachment #263542|review?, commit-queue?      |
              Flags|                            |
 Attachment #263628|                            |review?, commit-queue?
              Flags|                            |

--- Comment #14 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 263628
  --> https://bugs.webkit.org/attachment.cgi?id=263628&action=review
Updated patch

We needed a new expectation earlier, since for the newly found crashes, we were creating TestResult and adding to the list of TestResults and needed a way to differentiate between both type of crashes (so as to create separate sections in html page). However since we re-structed the json file and both type of crashes are stored in separate sections of json, we can do away with adding a new expectation. We just need some flag to differentiate test crashes from these new crashes (so as to add to correct section in json file). I have now used TestResult.is_other_crash flag for the same. Please review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/483ad1f3/attachment.html>