[Webkit-unassigned] [Bug 150171] ASSERTION FAILED: markFontData in FontCascade::emphasisMarkHeight

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150171

Myles C. Maxfield <mmaxfield at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263161|review?                     |review+
              Flags|                            |

--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 263161
  --> https://bugs.webkit.org/attachment.cgi?id=263161
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263161&action=review

> Source/WebCore/platform/graphics/FontCascade.cpp:1236
> +    return !glyphData.isEmpty();

This function should return an Optional(GlyphData) instead of using an out param.

Also, the U16_* macros can be cleaned up.

> Source/WebCore/platform/graphics/GlyphPage.h:53
> +    bool isEmpty() const { return !glyph && !font; }

Why don't you name this "invalid" or something? I'm not sure that "empty" is the best name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/a3f9c17f/attachment.html>