[Webkit-unassigned] [Bug 147824] NetworkProcess: DNS prefetch happens in the Web Process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147824

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263456|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #27 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 263456
  --> https://bugs.webkit.org/attachment.cgi?id=263456
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263456&action=review

r=me

> Source/WebKit2/WebProcess/WebProcess.cpp:167
> +    , m_dnsPrefetchedHostsCleanupHysteresis(std::bind(&WebProcess::dnsPrefetchedHostsCleanupHysteresisUpdated, this, std::placeholders::_1))

Could have also been all in one line:
, m_dnsPrefetchHysteresis([this] (HystererisState state) { if (state == HysteresisState::Stopped) m_dnsPrefetchedHosts.clear(); });

> Source/WebKit2/WebProcess/WebProcess.h:368
> +    WebCore::HysteresisActivity m_dnsPrefetchedHostsCleanupHysteresis;

I prefer the naming: m_dnsPrefetchHystereris. This way when the activity stops, it is clearer that what stopped is a DNS prefetching activity.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/f56fbaf3/attachment-0001.html>