[Webkit-unassigned] [Bug 147601] [INTL] Implement Intl.Collator.prototype.resolvedOptions ()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147601

--- Comment #9 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
Thanks for the review!

(In reply to comment #7)
> Don't forget to add your copyright on the files with significant changes.

Added my copyright to IntlCollatorConstructor.cpp and IntlObject.cpp. These are the source files that I add more than 100 lines.

> > Source/JavaScriptCore/runtime/IntlCollator.h:74
> > +    bool m_numeric;
> > +    String m_sensitivity;
> > +    bool m_ignorePunctuation;
> 
> Let's move the booleans together to improve packing a bit.

Done.

> > Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp:123
> >      // The function returns a new object whose properties and attributes are set as if constructed by an object literal assigning to each of the following properties the value of the corresponding internal slot of this Collator object (see 10.4): locale, usage, sensitivity, ignorePunctuation, collation, as well as those properties shown in Table 1 whose keys are included in the %Collator%[[relevantExtensionKeys]] internal slot of the standard built-in object that is the initial value of Intl.Collator.
> 
> Can you please break this comment over multiple lines?

Done.

> > Source/JavaScriptCore/runtime/IntlObject.cpp:631
> > +    String locale, noExtensionsLocale;
> 
> Please move noExtensionsLocale to its own line. One statement per
> declaration.

Done.

> > Source/JavaScriptCore/runtime/IntlObject.cpp:646
> > +            ASSERT(extensionIndex != notFound);
> 
> Let's make that a RELEASE_ASSERT().
> 
> I don't like the idea of a notFound accidentally being used for length
> computation.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/44c85879/attachment-0001.html>