[Webkit-unassigned] [Bug 150323] [GTK] Graphics corruption when entering/leaving AC mode quickly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150323

Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263558|review?                     |review+
              Flags|                            |

--- Comment #6 from Mario Sanchez Prada <mario at webkit.org> ---
Comment on attachment 263558
  --> https://bugs.webkit.org/attachment.cgi?id=263558
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263558&action=review

I've tried this patch locally and I can confirm it fixes all the glitches I could see so far, not only with the provided test case but also with the original problem that prompted me to report the issue.

I've also reviewed and it looks good to me, I only have a suggestion related to code readability, but overall I think this is good to land. Thanks Carlos!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h:75
> +void webkitWebViewBaseWillEnterAcceleratedCompositingMode(WebKitWebViewBase*);

I think I'd declare this method before webkitWebViewBaseEnterAcceleratedCompositingMode(), so that it's clear that these 3 callbacks are normally executed in that order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/16959c95/attachment.html>