[Webkit-unassigned] [Bug 150353] New: [CMake] GTK3 version is too low to support Wayland when Wayland is enabled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 20:11:41 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=150353

            Bug ID: 150353
           Summary: [CMake] GTK3 version is too low to support Wayland
                    when Wayland is enabled.
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: xuewen.ok at gmail.com
                CC: bugs-noreply at webkitgtk.org

When I run cmake build in my ubuntu 14.04 64-bit, cmake reports following errors:

CMake Error at Source/cmake/OptionsGTK.cmake:418 (message):
  GTK+ 3.12 is required to use ENABLE_WAYLAND_TARGET
Call Stack (most recent call first):
  CMakeLists.txt:123 (include)

My GTK+3 and Wayland version is 3.10.8 which is less than 3.12, but the Source/cmake/FindGTK3.cmake:61 set the GTK3_SUPPORTS_WAYLAND to true.
        set(GTK3_SUPPORTS_WAYLAND TRUE)

Should the FindGTK3.cmake limit the GTK+3 version to 3.12 to enable wayland? Like the following:

diff --git a/Source/cmake/FindGTK3.cmake b/Source/cmake/FindGTK3.cmake
index 6bc2649..f708dae 100644
--- a/Source/cmake/FindGTK3.cmake
+++ b/Source/cmake/FindGTK3.cmake
@@ -57,7 +57,7 @@ if (GTK3_VERSION AND VERSION_OK)
     endif ()

diff --git a/Source/cmake/FindGTK3.cmake b/Source/cmake/FindGTK3.cmake
index 6bc2649..d9eb88c 100644
--- a/Source/cmake/FindGTK3.cmake
+++ b/Source/cmake/FindGTK3.cmake
@@ -57,7 +57,7 @@ if (GTK3_VERSION AND VERSION_OK)
     endif ()

     pkg_check_modules(GTK3_WAYLAND gtk+-wayland-3.0)
-    if ("${GTK3_WAYLAND_VERSION}" VERSION_EQUAL "${GTK3_VERSION}")
+    if ("${GTK3_WAYLAND_VERSION}" VERSION_EQUAL "${GTK3_VERSION}" AND NOT("${GTK3_WAYLAND_VERSION}" VERSION_LESS "3.12"))
         set(GTK3_SUPPORTS_WAYLAND TRUE)
     else ()
         set(GTK3_SUPPORTS_WAYLAND FALSE)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/083520a8/attachment-0001.html>


More information about the webkit-unassigned mailing list