[Webkit-unassigned] [Bug 147601] [INTL] Implement Intl.Collator.prototype.resolvedOptions ()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147601

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262678|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 262678
  --> https://bugs.webkit.org/attachment.cgi?id=262678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262678&action=review

I did not find any error. Some minor comments:

> Source/JavaScriptCore/ChangeLog:3
> +        [INTL] Implement Intl.Collator.prototype.resolvedOptions ()

Don't forget to add your copyright on the files with significant changes.

> Source/JavaScriptCore/runtime/IntlCollator.h:74
> +    bool m_numeric;
> +    String m_sensitivity;
> +    bool m_ignorePunctuation;

Let's move the booleans together to improve packing a bit.

> Source/JavaScriptCore/runtime/IntlCollatorPrototype.cpp:123
>      // The function returns a new object whose properties and attributes are set as if constructed by an object literal assigning to each of the following properties the value of the corresponding internal slot of this Collator object (see 10.4): locale, usage, sensitivity, ignorePunctuation, collation, as well as those properties shown in Table 1 whose keys are included in the %Collator%[[relevantExtensionKeys]] internal slot of the standard built-in object that is the initial value of Intl.Collator.

Can you please break this comment over multiple lines?

> Source/JavaScriptCore/runtime/IntlObject.cpp:631
> +    String locale, noExtensionsLocale;

Please move noExtensionsLocale to its own line. One statement per declaration.

> Source/JavaScriptCore/runtime/IntlObject.cpp:646
> +            ASSERT(extensionIndex != notFound);

Let's make that a RELEASE_ASSERT().

I don't like the idea of a notFound accidentally being used for length computation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151019/8e620ce3/attachment.html>