[Webkit-unassigned] [Bug 145366] FTL is not working on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145366

--- Comment #66 from peavo at outlook.com ---
(In reply to comment #63)
> Comment on attachment 263482 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=263482&action=review
> 

Thanks for reviewing :)

> 
> > Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:722
> > +#if CPU(X86_64)
> > +    void loadDouble128(ImplicitAddress address, FPRegisterID src)
> > +    {
> > +        ASSERT(isSSE2Present());
> > +        m_assembler.movups_mr(src, address.offset, address.base);
> > +    }
> > +#endif
> 
> Why is this added?  I don't see it used anywhere in this patch.
> 

Removed. This was in preparation for saving and restoring all 16 bytes of callee saved xmm registers. I'll create another patch for this soon.

> 
> > Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:197
> > +    Call callJIT()
> > +    {
> > +        DataLabelPtr label = moveWithPatch(TrustedImmPtr(0), scratchRegister);
> > +        Call result = Call(m_assembler.call(scratchRegister), Call::Linkable);
> > +
> > +        ASSERT_UNUSED(label, differenceBetween(label, result) == REPTACH_OFFSET_CALL_R11);
> > +        return result;
> > +    }
> 
> Why is this added?  I don't see it used anywhere in this patch.
>

Removed, no longer used.

> 
> > Source/JavaScriptCore/ftl/FTLCapabilities.cpp:213
> > +    case ArithPow:
> > +#if OS(WINDOWS)
> > +        // LLVM does not support powi on Windows.
> > +        if (node->child2().useKind() == Int32Use)
> > +            return CannotCompile;
> > +#endif
> > +        break;
> 
> Is this still necessary?  In compileArithPow() below, you seem to have
> implemented support for (m_node->child2().useKind() == Int32Use) already
> (line 1843).  Or am I misreading it?
> 

You're right. Both are not needed. I kept this, since implementing support for powi using doublePow did not produce the exact correct result, causing a stress test failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151019/3d1ee797/attachment.html>