[Webkit-unassigned] [Bug 149873] [Content Extensions] Content blocking rules are not consulted for pings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149873

--- Comment #26 from Darin Adler <darin at apple.com> ---
(In reply to comment #24)
> > Not new to this patch, but I don’t understand why this doesn’t have to null check document() or securityOrigin().
> 
> I'll resubmit with null checks and without the local variable.
> 
> There are quite a few other places in PingLoader.cpp that dereference
> document() and securityOrigin() without checking for null. Maybe they should
> be addressed in another bug? Can I file a new bug report and fix them there?

Perhaps you misunderstood my comment.

It’s entirely possible that there is some guarantee that document() and securityOrigin() are non-null. If so, there is no need to add checks. But somehow the code needs to make clear where the guarantee that they are non-null comes from. Maybe one of the other contributors can help with this.

One reason for a guarantee could be that earlier code checks for the null case and this would never be called in that case. Another would be some more high level semantic guarantee that would prevent this code from being called when one or both of those would be null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/72c73556/attachment.html>