[Webkit-unassigned] [Bug 150173] New: [WK2] Simplify unused return warning in WKRetainPtr.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 09:02:04 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=150173

            Bug ID: 150173
           Summary: [WK2] Simplify unused return warning in WKRetainPtr.h
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ossy at webkit.org
                CC: andersca at apple.com, mitz at webkit.org

http://trac.webkit.org/changeset/159788/trunk/Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h
added (copy/pasted) a complex definition to do it without including Compiler.h from WTF.

But now WARN_UNUSED is defined to __attribute__((__warn_unused_result__))
if the compiler is GCC or Clang. But it is a WebKit2 file, I don't
know if any other compiler is supported.
http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Compiler.h#L308

I think we can simply use __attribute__((__warn_unused_result__)) unconditionally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/91f8f7af/attachment.html>


More information about the webkit-unassigned mailing list