[Webkit-unassigned] [Bug 150137] IdentifierRepHash has a mismatch between hash() and equal()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150137

--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
(In reply to comment #1)
> I don't remember the exact bug number (maybe, in the context of Symbol and
> IdentifierRepHash), IIRC, when I attempt to change this to PtrHash, I heard
> the following reason why we did not use PtrHash; We intentionally use
> StringHasher instead of PtrHash because it gives nicer distribution for
> Strings and reduces collisions in the hash table.
> So when changing this, I think measuring collision and performance is nice.

Personally I guess PtrHash gives nice distribution. PtrHash maps intptr_t => unsigned. StringHasher maps UChar[arbitrary length] => unsigned. If PtrHash works well, it could provide nice distribution in this case I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/906399c4/attachment-0001.html>