[Webkit-unassigned] [Bug 148388] We should also store the time information for recent searches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148388

--- Comment #48 from Zach Li <zacharyli323 at gmail.com> ---
(In reply to comment #47)
> Comment on attachment 262998 [details]
> Revised Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262998&action=review
> 
> > Source/WebCore/platform/SearchPopupMenu.h:42
> > +    virtual void saveRecentSearches(const AtomicString& name, const Vector<RecentSearch>& searchItems) = 0;
> 
> No need for the second argument to have a name; searchItems is redundant
> with the type Vector<RecentSearch>.

Will change.

> 
> > Source/WebCore/platform/SearchPopupMenu.h:43
> > +    virtual void loadRecentSearches(const AtomicString& name, Vector<RecentSearch>& searchItems) = 0;
> 
> No need for the second argument to have a name; searchItems is redundant
> with the type Vector<RecentSearch>.

Will change.

> 
> We should come back and change this function to use a return value instead
> of an out argument in a later patch.

Okay.

> 
> > Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:87
> > +        for (auto searchItem : searchItems)
> 
> This should be auto& rather than auto, since we have no need to copy each
> searchItem as we iterate the vector.

Oops.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/fdb5d9d6/attachment.html>