[Webkit-unassigned] [Bug 149873] [Content Extensions] Content blocking rules are not consulted for pings (<a ping>)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149873

--- Comment #16 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 262988
  --> https://bugs.webkit.org/attachment.cgi?id=262988
Patch (fails one test)

View in context: https://bugs.webkit.org/attachment.cgi?id=262988&action=review

This is great! We could probably land this without the one failing test, then address that in a different bug.  Please upload another patch, which will probably be pretty close to landing

> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:173
> +    } else if (blockedStatus == BlockedStatus::BlockedCookies) {
> +        request.setAllowCookies(false);
> +    }

There are lots of places you use {} around single lines, which WebKit style doesn't like.  https://www.webkit.org/coding/coding-style.html Use Tools/Scripts/check-webkit-style to check this.

> Source/WebCore/loader/PingLoader.cpp:96
> +        request.setAllowCookies(false);

Why not call processContentExtensionRulesForLoad with this request instead of making a new function processContentExtensionRulesForPing?  I think that would be even cleaner.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151013/3f61897f/attachment-0001.html>