[Webkit-unassigned] [Bug 148867] input[type=number] does not sanitize value properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148867

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 262940
  --> https://bugs.webkit.org/attachment.cgi?id=262940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262940&action=review

> Source/WebCore/ChangeLog:3
> +        input[type=number] does not sanitize value properly

The bug title needs to be updated to reflect your actual change.

> Source/WebCore/ChangeLog:14
> +        Updated the following tests:

test (singular)

> Source/WebCore/ChangeLog:15
> +        * fast/forms/number/number-stepup-stepdown-from-renderer-expected.txt:

Drop this line.

> Source/WebCore/ChangeLog:16
> +        * fast/forms/number/number-stepup-stepdown-from-renderer.html:

Use - instead of * to avoid confusing our tools and drop the semicolon at the end.

> LayoutTests/fast/forms/number/number-stepup-stepdown-from-renderer.html:110
> +debug('Normal cases with unusual input')

I think it would be interesting to add coverage for values with a 0 after the dot (e.g. '1.0') to show that the results are consistent. We also probably want to cover a different step interval than 1 (e.g. '1.0' and '1.' with a step interval of 0.1 so we end up with 1.1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151013/167d941c/attachment.html>