[Webkit-unassigned] [Bug 148388] We should also store the time information for recent searches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148388

--- Comment #38 from Darin Adler <darin at apple.com> ---
Comment on attachment 262822
  --> https://bugs.webkit.org/attachment.cgi?id=262822
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262822&action=review

>> Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:137
>> +        searchItems.append({ String { searchString }, toSystemClockTime(date) });
> 
> No space after String before the "{" as I mentioned in my last review.

Sorry that I missed your comment last time about being driven by a complaint from the style checker.

>> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:95
>> +            searchItems.append({ String { item }, std::chrono::system_clock::time_point::min() });
> 
> No space after String before the "{" as I mentioned in my last review.

Sorry that I missed your comment last time about being driven by a complaint from the style checker.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151012/dd79d2c5/attachment.html>