[Webkit-unassigned] [Bug 144557] [GTK] OSX linker doesn't understand --whole-archive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144557

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262929|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #10 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 262929
  --> https://bugs.webkit.org/attachment.cgi?id=262929
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262929&action=review

Looks good, but I want to suggest one small thing before committing the patch.

> Source/WebKit2/PlatformGTK.cmake:929
> +    set(DARWIN_ADDITIONAL_LIBRARIES --library=c++)
> +    set(DARWIN_ADDITIONAL_LDFLAGS -lGObjectDOMBindings)

Do you mind renaming these to INTROSPECTION_ADDITIONAL_LIBRARIES and INTROSPECTION_ADDITIONAL_LDFLAGS to make it consistent with INTROSPECTION_ADDITIONAL_LIBRARY_PATH?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151012/fb089191/attachment.html>