[Webkit-unassigned] [Bug 144557] [GTK] OSX linker doesn't understand --whole-archive
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 12 09:21:06 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=144557
Martin Robinson <mrobinson at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #252688|review?, commit-queue? |review-
Flags| |
--- Comment #4 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 252688
--> https://bugs.webkit.org/attachment.cgi?id=252688
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=252688&action=review
Seems sensible to me, but this patch needs a bit of work. Thanks!
> Source/WebKit2/PlatformGTK.cmake:549
> -ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES)
> +if (CMAKE_SYSTEM_NAME MATCHES "Linux")
> + ADD_WHOLE_ARCHIVE_TO_LIBRARIES(WebKit2_LIBRARIES)
> +endif ()
It would be better to add this check to the ADD_WHOLE_ARCHIVE_TO_LIBRARIES macro instead of requiring it for every invocation.
> Source/WebKit2/PlatformGTK.cmake:875
> - COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=
> + COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations LDFLAGS=-lGObjectDOMBindings
This looks unrelated.
> Source/WebKit2/PlatformGTK.cmake:890
> + --library=c++
Ditto.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151012/4eafae30/attachment-0001.html>
More information about the webkit-unassigned
mailing list