[Webkit-unassigned] [Bug 149873] [Content Extensions] Content blocking rules are not consulted for pings (<a ping>)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149873

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262754|review?                     |review-
              Flags|                            |

--- Comment #9 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 262754
  --> https://bugs.webkit.org/attachment.cgi?id=262754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262754&action=review

> Source/WebCore/loader/PingLoader.cpp:98
> +#if ENABLE(CONTENT_EXTENSIONS)

We should go further and handle the 3 types of requests from PingLoader. Ping can be used to track users, this is an oversight.

Can you please add an utility function with the Content Blocker code and call it from the 3 source of requests?
That should be done on entry, not after creating the request.

>> LayoutTests/ChangeLog:3
>> +        Tests to ensure content blocking rules are respected for "<a ping>" pings
> 
> Hooray!  Tests!

+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151010/1226e63d/attachment-0001.html>