[Webkit-unassigned] [Bug 149919] New: Fix the WASM build on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149919

            Bug ID: 149919
           Summary: Fix the WASM build on Linux
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ossy at webkit.org
                CC: ggaren at apple.com, mark.lam at apple.com,
                    msaboff at apple.com, sbarati at apple.com,
                    sukolsak at gmail.com

build error #1
---------------
../../Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp: In member function 'JSC::StackVisitor::Status Inspector::CreateScriptCallStackFunctor::operator()(JSC::StackVisitor&)':
../../Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp:70:37: error: invalid use of incomplete type 'class JSC::CodeBlock'
In file included from ../../Source/JavaScriptCore/interpreter/JSStack.h:33:0,
                 from ../../Source/JavaScriptCore/interpreter/CallFrame.h:27,
                 from ../../Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp:36:
../../Source/JavaScriptCore/interpreter/Register.h:38:11: error: forward declaration of 'class JSC::CodeBlock'

-----> fix: CodeBlock.h should be included


build error #2
---------------
In file included from ../../Source/JavaScriptCore/wasm/WASMFunctionParser.cpp:34:0:
../../Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h:37:12: error: 'JSC::FTL::LBasicBlock' has not been declared
../../Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h:38:12: error: 'JSC::FTL::LValue' has not been declared
../../Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h:42:13: error: 'LValue' does not name a type

... [SNIP] ...

-----> fix: These symbols are FTL specific, we should add an ENABLE(FTL_JIT) guard for the whole file.


build error #3
---------------
In file included from ../../Source/JavaScriptCore/wasm/WASMFunctionParser.cpp:33:0:
../../Source/JavaScriptCore/wasm/WASMFunctionCompiler.h: In function 'size_t JSC::sizeOfMemoryType(JSC::WASMMemoryType)':
../../Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:97:1: error: control reaches end of non-void function [-Werror=return-type]

-----> fix: We need an unreachable return to make GCC happy.


build error #4
---------------
Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/JSWASMModule.cpp.o:JSWASMModule.cpp:function JSC::JSWASMModule::visitChildren(JSC::JSCell*, JSC::SlotVisitor&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/JSWASMModule.cpp.o:JSWASMModule.cpp:function JSC::JSWASMModule::visitChildren(JSC::JSCell*, JSC::SlotVisitor&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/JSWASMModule.cpp.o:JSWASMModule.cpp:function JSC::JSWASMModule::visitChildren(JSC::JSCell*, JSC::SlotVisitor&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)'
collect2: error: ld returned 1 exit status

-----> fix: We should include JSCJSValueInlines.h too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151008/c49befed/attachment.html>