[Webkit-unassigned] [Bug 149820] WebCore::IOSurface should ask the IOSurface for the pixel format instead of caching it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149820

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262470|1                           |0
        is obsolete|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 262470
  --> https://bugs.webkit.org/attachment.cgi?id=262470
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262470&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:242
> +    if (pixelFormat == 'BGRA')
> +        return Format::RGBA;

I wonder if we should call the format BGRA since that's what it really is

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:243
> +#if PLATFORM(IOS)

Why is this (and the other yuv stuff) iOS specific? Only the transform part should be iOS specific.

That will fix your build error, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151005/6afc3ad6/attachment.html>