[Webkit-unassigned] [Bug 149807] [Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 5 15:18:47 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=149807

--- Comment #4 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
(In reply to comment #2)
> Comment on attachment 262439 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=262439&action=review
> 
> Ok
> 
> > Source/JavaScriptCore/runtime/IntlCollatorConstructor.cpp:152
> > +    const Vector<String>& requestedLocales = canonicalizeLocaleList(exec, exec->argument(0));
> 
> IMHO, using Vector<String> makes the lifetime clearer.

Thanks! Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151005/96a0c0f8/attachment.html>


More information about the webkit-unassigned mailing list