[Webkit-unassigned] [Bug 145366] FTL is not working on Windows.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145366

--- Comment #56 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 262334
  --> https://bugs.webkit.org/attachment.cgi?id=262334
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262334&action=review

I have a few nits about the build system changes.

> Source/JavaScriptCore/CMakeLists.txt:846
> +    if (NOT LLVM_STATIC_LIBRARIES AND NOT MSVC)

Please use WIN32 instead of MSVC.  It causes fewer warnings when running cmake and until someone builds webkit with mingw or clang, they're the same thing.

> Source/JavaScriptCore/CMakeLists.txt:876
> +        target_link_libraries(llvmForJSC "LLVMAnalysis.lib;LLVMAsmParser.lib;LLVMAsmPrinter.lib;LLVMBitReader.lib;LLVMBitWriter.lib;LLVMCodeGen.lib;LLVMCore.lib;LLVMDebugInfo.lib;LLVMExecutionEngine.lib;LLVMInstCombine.lib;LLVMInstrumentation.lib;LLVMInterpreter.lib;LLVMipa.lib;LLVMipo.lib;LLVMIRReader.lib;LLVMJIT.lib;LLVMLinker.lib;LLVMLTO.lib;LLVMMC.lib;LLVMMCDisassembler.lib;LLVMMCJIT.lib;LLVMMCParser.lib;LLVMObjCARCOpts.lib;LLVMObject.lib;LLVMOption.lib;LLVMRuntimeDyld.lib;LLVMScalarOpts.lib;LLVMSelectionDAG.lib;LLVMSupport.lib;LLVMTableGen.lib;LLVMTarget.lib;LLVMTransformUtils.lib;LLVMVectorize.lib;LLVMX86AsmParser.lib;LLVMX86AsmPrinter.lib;LLVMX86CodeGen.lib;LLVMX86Desc.lib;LLVMX86Disassembler.lib;LLVMX86Info.lib;LLVMX86Utils.lib;LLVMProfileData.lib")

These should be in LLVM_STATIC_LIBRARIES.

> Source/cmake/OptionsWin.cmake:39
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTL_JIT PRIVATE ON)

Shouldn't this only be enabled for the 64-bit build?

> Tools/Scripts/webkitdirs.pm:1888
> +    if (isWin64()) {

&& !canUseNinja()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151002/af82a1cd/attachment.html>