[Webkit-unassigned] [Bug 149741] "Plug-in is blocked" message doesn't draw correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149741

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 262322
  --> https://bugs.webkit.org/attachment.cgi?id=262322
First patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262322&action=review

Seems reasonable to me but Anders is the best person for plugin patches; Ccing him.

> Source/WebCore/ChangeLog:4
> +

No newline here.

> Source/WebCore/ChangeLog:6
> +        <rdar://problem/22920949>
> +        https://bugs.webkit.org/show_bug.cgi?id=149741

These are backwards IMO (but nobody strictly follows any rule here anyway).

> Source/WebCore/ChangeLog:12
> +        No new tests are added.

Why not? From a cursory glance, this seems testable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151002/53a2d703/attachment.html>