[Webkit-unassigned] [Bug 149338] [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 30 12:58:29 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=149338
Saam Barati <sbarati at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #266216|review? |review+
Flags| |
--- Comment #131 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 266216
--> https://bugs.webkit.org/attachment.cgi?id=266216
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=266216&action=review
> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:132
> + UnlinkedFunctionExecutable(VM*, Structure*, const SourceCode&, RefPtr<SourceProvider>&& sourceOverride, FunctionMetadataNode*, UnlinkedFunctionKind, ConstructAbility, VariableEnvironment&, bool);
Style: Can we name this bool in a follow up patch.
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2590
> + instructions().append(0);
Lets remove this argument in a follow up patch
> Source/JavaScriptCore/runtime/Executable.h:463
> + EvalExecutable(ExecState*, const SourceCode&, bool, bool, bool);
style: Lets name these bools in a follow up patch.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151130/2d780458/attachment.html>
More information about the webkit-unassigned
mailing list