[Webkit-unassigned] [Bug 30381] [Qt] Using QWebView crashes the application on FreeBSD

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 29 20:09:39 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=30381

--- Comment #4 from Bobby <bsee095 at gmail.com> ---
Subversion Revision: 95990
diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 612eb050619279b212d7d47db765511f8b0c113c..889b68ef5a15408d244b99fc1360b0c792700f1b 100644
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,12 @@
+2011-09-27  Tom Zakrajsek  <tomz at codeaurora.org>
+
+        webkit-patch doesn't like UTF-8 characters in reviewers names
+        https://bugs.webkit.org/show_bug.cgi?id=63452
+
+        Reviewed by NOBODY (OOPS!).
+
+        * Scripts/webkit-patch:
+
 2011-09-26  Adam Roben  <aroben at apple.com>

         Clean up code imported from WebKitAPITest
diff --git a/Tools/Scripts/webkit-patch b/Tools/Scripts/webkit-patch
index 159985f8a004d1cba223affcb051446a4f821f7e..91e4c0f9aa455e359cbe01d7498745be32a90847 100755
--- a/Tools/Scripts/webkit-patch
+++ b/Tools/Scripts/webkit-patch
@@ -1,4 +1,5 @@
 #!/usr/bin/env python
+# Copyright (c) 2011 Code Aurora Forum. All rights reserved.
 # Copyright (c) 2010 Google Inc. All rights reserved.
 # Copyright (c) 2009 Apple Inc. All rights reserved.
 # Copyright (C) 2010 Chris Jerdonek (cjerdonek at webkit.org)
@@ -35,6 +36,13 @@ import logging
 import os
 import signal
 import sys
+import codecs
+
+# By default, sys.stdout assumes ascii encoding.  Since our messages can
+# contain unicode strings (as with some peoples' names) we need to apply
+# the utf-8 codec to prevent throwing and exception.
+# Not having this was the cause of https://bugs.webkit.org/show_bug.cgi?id=63452.
+sys.stdout = codecs.lookup('utf-8')[-1](sys.stdout)

 from webkitpy.common.system.logutils import configure_logging
 import webkitpy.python24.versioning as versioning

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151130/41ddcde8/attachment.html>


More information about the webkit-unassigned mailing list