[Webkit-unassigned] [Bug 151391] [GLIB] Implement garbage collector timers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151391

Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at webkit.org

--- Comment #21 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
(In reply to comment #10)
> Because this would work for any other port using glib, like WebKit4Wayland,
> EFL is the exception here, not glib.
> 
> > > Source/JavaScriptCore/heap/HeapTimer.cpp:41
> > >  #if PLATFORM(EFL)
> > >  #include <Ecore.h>
> > > +#elif USE(GLIB)
> > > +#include <glib.h>
> > >  #endif
> > 
> > Just one example, you end up doing this. It's counter-intuitive because
> > PLATFORM(EFL) falls under USE(GLIB), but you still have to special-case it
> > because of the different implementations.
> 
> Yes, because EFL uses GLIB but its own timer implementation. The EFL
> implementation is specific to EFL, but the GLIB one is not specific to GTK.
> 

EFL port has been used GLIB to use libsoup, gstreamer and other minor functionalities. However our policy is to consider to use EFL library first if EFL supports the library we need to use. In this case we should keep PLATFORM(EFL) for timer because we implements it using ECore_Timer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151127/18440d69/attachment-0001.html>