[Webkit-unassigned] [Bug 151569] [Win] Implement methods to get and set inner html.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151569

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266093|review?                     |review+
              Flags|                            |

--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 266093
  --> https://bugs.webkit.org/attachment.cgi?id=266093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266093&action=review

This looks a lot like the innerText implementation just below it :)
r=me, mac test failures unrelated.

> Source/WebKit/win/DOMHTMLClasses.cpp:507
> +    String innerHtmlString = downcast<HTMLElement>(m_element)->innerHTML();

innerHTMLString

> Source/WebKit/win/DOMHTMLClasses.cpp:515
> +    HTMLElement* htmlElement = downcast<HTMLElement>(m_element);

Why don't you also rename setInnerText's htmlEle to htmlElement while you're at it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151123/9d41aca9/attachment.html>