[Webkit-unassigned] [Bug 151391] [GLIB] Implement garbage collector timers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151391

--- Comment #11 from Zan Dobersek <zan at falconsigh.net> ---
(In reply to comment #10)
> (In reply to comment #9)
> > Comment on attachment 265749 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=265749&action=review
> > 
> > >>> Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:33
> > >>> +#if USE(CF) || USE(GLIB)
> > >> 
> > >> Is USE(GLIB) also true for EFL? I wonder if it wouldn't be better to be more explicit here for the sake of code readability and leave this as:
> > >> 
> > >> #if USE(CF) || PLATFORM(EFL) || USE(GLIB)
> > > 
> > > Yes, it's true.
> > 
> > Why USE(GLIB) then? It's true for both EFL and GTK, but the implementations
> > of HeapTimer differ for the two ports.
> > 
> > Since all these classes are based on HeapTimer, I think the PLATFORM(EFL) ||
> > PLATFORM(GTK) should be used throughout this patch, instead of bundling them
> > under USE(GLIB).
> 
> Because this would work for any other port using glib, like WebKit4Wayland,
> EFL is the exception here, not glib.
> 

Makes me wish for USE(ECORE) then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151119/5aa1639f/attachment.html>