[Webkit-unassigned] [Bug 151324] REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 18 15:39:09 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=151324
--- Comment #20 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 265765
--> https://bugs.webkit.org/attachment.cgi?id=265765
Proposal for further reducing re-parsing
View in context: https://bugs.webkit.org/attachment.cgi?id=265765&action=review
This seems like a more efficient approach. Can you merge it into your previous patch and rebase to trunk?
> Source/JavaScriptCore/parser/Parser.cpp:2727
> + ExpressionErrorClassifier classification(this);
Let's call this classifier to match its class name.
> Source/JavaScriptCore/parser/Parser.h:740
> + enum ErrorClass {
Let's call this ExpressionErrorClass.
> Source/JavaScriptCore/parser/Parser.h:748
> + , m_outerClassifier(parser->m_errorClassifier)
Let's call this m_previous.
> Source/JavaScriptCore/parser/Parser.h:759
> + void classifyError(ErrorClass classification)
Let's call this classifyExpressionError.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/35f32fc3/attachment.html>
More information about the webkit-unassigned
mailing list