[Webkit-unassigned] [Bug 150353] [CMake] GTK3 version is too low to support Wayland when Wayland is enabled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150353

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com

--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
You can also disable the wayland target (is enabled by default) if you don't want to run webkitgtk+ on wayland.

Passing -DENABLE_WAYLAND_TARGET=OFF to cmake will do that.

If you use the script build-webkit you can do that as follows:

Tools/Scripts/build-webkit --gtk --release --cmakeargs='-DENABLE_WAYLAND_TARGET=OFF'


Regarding your proposed patch, maybe a better alternative would be to lower the required GTK+ version to 3.10 when building wayland. I'm not sure if we really require 3.12 or we can lower this requirement to 3.10

You can try this patch:

--- a/Source/cmake/OptionsGTK.cmake
+++ b/Source/cmake/OptionsGTK.cmake
@@ -433,8 +433,8 @@ if (ENABLE_WAYLAND_TARGET)
         message(FATAL_ERROR "Recompile GTK+ with Wayland backend to use ENABLE_WAYLAND_TARGET")
     endif ()

-    if (ENABLE_WAYLAND_TARGET AND GTK3_VERSION VERSION_LESS 3.12)
-        message(FATAL_ERROR "GTK+ 3.12 is required to use ENABLE_WAYLAND_TARGET")
+    if (ENABLE_WAYLAND_TARGET AND GTK3_VERSION VERSION_LESS 3.10)
+        message(FATAL_ERROR "GTK+ 3.10 is required to use ENABLE_WAYLAND_TARGET")
     endif ()

     find_package(Wayland REQUIRED)


And try to see if everything build ok (including the wayland target)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/c887ad9b/attachment.html>