[Webkit-unassigned] [Bug 150987] Web Inspector: Dashboard weight/size should show transferred size not total resources size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150987

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265728|review?                     |review-
              Flags|                            |

--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 265728
  --> https://bugs.webkit.org/attachment.cgi?id=265728
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265728&action=review

>> Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js:153
>> +            this.transferredSize = event.target.mainResource.transferSize;
> 
> This still needs an explanation. Why not include the transferSize of the main resource when cached? At the least, I suspect we do a "if modified since" check on the main resource.

As was mentioned previous, r- until we get an answer to this question.

Also, I know you are working on a test for WebInspector.Resource. I think that is important for this patch so we can better guarantee `transferSize` is what we want it to be and that this feature won't regress in the future!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/0e6cf7c6/attachment.html>