[Webkit-unassigned] [Bug 151391] [GLIB] Implement garbage collector timers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151391

--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 265749
  --> https://bugs.webkit.org/attachment.cgi?id=265749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265749&action=review

Great work! I noticed this was missing yesterday too, so I'm very happy that you fixed it. I just have a couple quick questions before I feel comfortable giving an r+...

> Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:33
> -#if USE(CF) || PLATFORM(EFL)
> +#if USE(CF) || USE(GLIB)

Is USE(GLIB) also true for EFL? I wonder if it wouldn't be better to be more explicit here for the sake of code readability and leave this as:

#if USE(CF) || PLATFORM(EFL) || USE(GLIB)

> Source/JavaScriptCore/heap/HeapTimer.cpp:155
> +        if (g_source_get_ready_time(source) == -1)
> +            return G_SOURCE_CONTINUE;

In what circumstances can this happen?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/c5637a62/attachment-0001.html>