[Webkit-unassigned] [Bug 151139] [GTK] Web Process crashes on reparenting a WebView with AC mode on

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151139

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #11)
> Basically, it would be applying this patch on top of Carlos's last one:
> 
> --- a/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
> +++ b/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp
> @@ -145,8 +145,10 @@ LayerTreeHostGtk::LayerTreeHostGtk(WebPage* webPage)
>  
>  bool LayerTreeHostGtk::makeContextCurrent()
>  {
> -    if (!m_layerTreeContext.contextID)
> +    if (!m_layerTreeContext.contextID) {
> +        m_context = nullptr;
>          return false;
> +    }
> 
> 
> I've tested this locally and it fixes the issue for me reliably, both in
> Release and Debug builds. 
> 
> Carlos, what do you think?

I think you write too much :-) awesome analysis, and I agree with your solution, makeContextCurrent() is the one creating the context, so look like a good place to delete it also when the ID becomes 0. I'll submit a new patch. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151116/fe6c7562/attachment.html>