[Webkit-unassigned] [Bug 151256] [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151256

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #6)
> Comment on attachment 265476 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265476&action=review
> 
> >>>> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:380
> >>>> +    }
> >>> 
> >>> Would RunLoop::run() not set up a nested main loop in case of running this in the main thread?
> >>> 
> >>> What about the cases where the bus is created in a non-main WebWorker thread that's also managed via RunLoop, wouldn't that set up the nested loop?
> >> 
> >> Yes, but with the same main context, we need a different one to avoid deadlocks. Phil wrote the original code, so he should know the details.
> > 
> > My bad, workers don't use RunLoop, they use a custom queue.
> 
> On that note, the new code goes on to create a RunLoop object in the worker
> thread.
> 
> I'd rather avoid that, and just use a new thread regardless where the
> AudioBus creation is requested (the main thread or a worker thread).

Ok, it's definitely safer and makes the code simpler.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151116/1bd5cd11/attachment.html>