[Webkit-unassigned] [Bug 151300] REGRESSION(r8780): Backwards delete by word incorrectly appends deleted text to kill ring, should be prepend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151300

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Backwards delete by word    |REGRESSION(r8780):
                   |incorrectly appends deleted |Backwards delete by word
                   |text to kill ring, should   |incorrectly appends deleted
                   |be prepend                  |text to kill ring, should
                   |                            |be prepend

--- Comment #1 from Brian Burg <bburg at apple.com> ---
I am not even kidding about the title change, Darin regressed this almost 11 years ago:

http://trac.webkit.org/changeset/8780


The relevant mistake can be seen here, where the code no longer computes 'prepend' based on the selection direction, nor does it change to disambiguate inside _deleteRange using the passed-in deletion type enum.

https://github.com/WebKit/webkit/commit/05b622f#diff-2929972b50734b9742ad9676920551a0L4153

Sorry Darin! This should not be too difficult to fix, though the code has moved about 30 times in 11 years. Might take a while to find the exact place to do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151116/d64b6a32/attachment-0001.html>