[Webkit-unassigned] [Bug 151256] [GStreamer] Use RunLoop instead of GMainLoop in AudioFileReaderGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151256

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 265476
  --> https://bugs.webkit.org/attachment.cgi?id=265476
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265476&action=review

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:380
> +    if (isMainThread()) {
> +        RefPtr<AudioBus> returnValue;
> +        auto threadID = createThread("AudioFileReader", [&returnValue, filePath, mixToMono, sampleRate] {
> +            returnValue = AudioFileReader(filePath).createBus(sampleRate, mixToMono);
> +        });
> +        waitForThreadCompletion(threadID);
> +
> +        return returnValue;
> +    }

Would RunLoop::run() not set up a nested main loop in case of running this in the main thread?

What about the cases where the bus is created in a non-main WebWorker thread that's also managed via RunLoop, wouldn't that set up the nested loop?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151114/b258c632/attachment.html>