[Webkit-unassigned] [Bug 151270] Add SPI for handling inline link navigation for peek/pop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151270

--- Comment #3 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 265492
  --> https://bugs.webkit.org/attachment.cgi?id=265492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265492&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:40
> + at class _WKPreviewingElementInfo;

“previewing element” sound a little weird, because the element isn’t doing any previewing, it is being previewed perhaps, so maybe _WKPreviewedElementInfo or _WKPreviewableElementInfo fit better.

> Source/WebKit2/UIProcess/API/Cocoa/_WKElementInfo.mm:59
> +    return _URL.get();

Because BOOL is sometimes just an unsigned char, this will return NO if the URL pointer ends in a 0 byte, so you should !! it or explicitly compare to nil.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151113/aec48e04/attachment.html>