[Webkit-unassigned] [Bug 150941] [WinCairo][Video][MediaFoundation] Video should be rendered in provided graphics context.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150941

--- Comment #17 from peavo at outlook.com ---
(In reply to comment #16)
> Comment on attachment 265074 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265074&action=review
> 
> This looks great! I have a few suggestions before landing, but I think it
> looks good.
> 

Thanks for reviewing!

> 
> > Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:1880
> > +    hr = m_mixer->ProcessOutput(0, 1, &dataBuffer, &status);
> 
> Are there conditions where m_mixer can be null? If not, maybe we should
> access it through a reference instead.
> 

Yes, it can be null during shutdown :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151109/886bc9f9/attachment.html>