[Webkit-unassigned] [Bug 147604] [INTL] Implement Collator Compare Functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147604

--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 264986
  --> https://bugs.webkit.org/attachment.cgi?id=264986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264986&action=review

> Source/JavaScriptCore/runtime/IntlCollator.cpp:98
> +                String collation(keywordValue);

Are these keyword value strings encoded as ASCII, Latin-1, or UTF-8? If the answer is ASCII or Latin-1, then this code is OK. If the answer is UTF-8, then this line should be:

    String collation = String::fromUTF8(keywordValue);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151108/40479c29/attachment.html>