[Webkit-unassigned] [Bug 150996] New: Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150996

            Bug ID: 150996
           Summary: Node.h:392:12: warning: 'this' pointer cannot be null
                    in well-defined C++ code
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

WebCore::Node::document begins with the line ASSERT(this), which is bogus. In Clang 3.7, this triggers a compiler warning for every file that includes Node.h:

../../Source/WebCore/dom/Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
        (!(this) ? (WTFReportAssertionFailure("../../Source/WebCore/dom/Node.h", 392, __PRETTY_FUNCTION__, "this"), WTFCrash()) : (void)0);
         ~ ^~~~
1 warning generated.

Pretty sure GCC and Clang both optimize away this assertion, but I guess the warning is new. The fix is just to remove the assertion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151107/b612e0d0/attachment.html>