[Webkit-unassigned] [Bug 150944] Layout Test accessibility/win/linked-elements.html is crashing on win debug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150944

Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264933|                            |review?
              Flags|                            |

--- Comment #5 from Mario Sanchez Prada <mario at webkit.org> ---
Created attachment 264933
  --> https://bugs.webkit.org/attachment.cgi?id=264933&action=review
Patch proposal

I was trying all sort of things to try to reproduce a similar crash in the GTK+ port but I couldn't so I proposing an speculative fix instead.

As I understand it, the problem is that now I moved those ASSERTs from AccessibilityNodeObject down to AccessibilityRenderObject, we are hitting those checks way more often for objects with an associated renderer since AccessibilityNodeObject::textUnderElement is not executed that often in this case.

So, the checks will probably need to be more precise to avoid being too paranoid, as for instance we don't need to worry about having an stable subtree when we are either going through a RenderText object or not in 'IncludeAllChildren' mode.

Looking at the backtrace, I can see that WebCore::AccessibilityRenderObject::nameForMSAA() calls textUnderElement() with the default mode, so I understand the attached patch should get rid of the crash in Win Debug bots.

Hope this helps

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151106/15f300ad/attachment-0001.html>