[Webkit-unassigned] [Bug 144938] WebCrypto: RSASSA-PKCS1-v1_5 generated keys can not be exported

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144938

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264914|review?                     |review-
              Flags|                            |

--- Comment #14 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 264914
  --> https://bugs.webkit.org/attachment.cgi?id=264914
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264914&action=review

Looks good to me. Marking r- because there are minor nits that needs to be addressed.

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:49
> +enum HashRequirement {

Please use a strongly typed enum (enum class).

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:50
> +    HashIsOptional = 0,

No need for a value here.

> Source/WebCore/bindings/js/JSCryptoAlgorithmDictionary.cpp:121
> +        if (HashIsRequired == isRequired)

While it is sometimes recommended to put constants at the left to avoid accidental assignment, this is not a style we use in WebKit. We prefer readability over catching such mistakes, which are caught by compiler warnings and by tests anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151106/e5d3aff7/attachment.html>